feature: Hide PosixDiskEnv type behind a feature (default enabled)
#38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much! I've left a few comments, but overall it looks good. |
dermesser
requested changes
Sep 7, 2023
Thanks for the feedback :) I adapted the code according to your comments. |
|
@dermesser Is this good to merge, then? |
dermesser
approved these changes
Sep 14, 2023
|
Yes apologies for the delay. I will shortly release a new major version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building
rusty-leveldbin constrained or non-POSIX environments (such as WASM) is currently not possible.This PR adds small changes to make it possible.
Changes
Introduces
fsfeature which is enabled by default. The feature allows to toggle thePosixDiskEnvtype and therefore makes it possible to buildrusty-leveldbon systems wherestd::iois constrained. One major use case are WASM environments. Users can therefore setuse-default-features = falseonrusty-leveldbdependency entries in theirCargo.toml. The only availableEnvwill beMemEnviffsfeature is disabled.Updates
randcrate to version0.8.5which is also WASM compatible. When the users ofrusty-leveldbaddgetrandomdependency to theirCargo.toml, it will make the random number generation inrusty-leveldbwork on their platform.Adds
crate-typeto allow builds in different environmentsRe-exports
FileLock,RandomAccessFileandLoggertypes so that users can add custom implementation of theEnvtrait.